search

dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
74 stars 20 forks source link

Fix multiple decoding issues #123

Closed DJBen closed 5 years ago

DJBen commented 5 years ago

name-list, headers, formatted-text etc. Reducing LilyPondTest suite failures to 73 69.

codecov-io commented 5 years ago

Codecov Report

Merging #123 into latest will increase coverage by 5.93%. The diff coverage is 92.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest     #123      +/-   ##
==========================================
+ Coverage   45.38%   51.32%   +5.93%     
==========================================
  Files         218      218              
  Lines        2580     2638      +58     
==========================================
+ Hits         1171     1354     +183     
+ Misses       1409     1284     -125
Impacted Files Coverage Δ
Sources/MusicXML/Complex Types/Header.swift 100% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/ScorePart.swift 100% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Ornament.swift 60.29% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Lyric.swift 0% <0%> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Rest.swift 100% <100%> (ø) :arrow_up:
...urces/MusicXML/Complex Types/EmptyTrillSound.swift 100% <100%> (+100%) :arrow_up:
Sources/MusicXML/Complex Types/PrintStyle.swift 100% <100%> (+100%) :arrow_up:
Sources/MusicXML/Complex Types/NameDisplay.swift 75.86% <100%> (+75.86%) :arrow_up:
Sources/MusicXML/Complex Types/TrillSound.swift 100% <100%> (+100%) :arrow_up:
...ces/MusicXML/Complex Types/Partwise/Partwise.swift 100% <100%> (ø) :arrow_up:
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b50fb13...3049eaa. Read the comment docs.

DJBen commented 5 years ago

Amended.

jsbean commented 5 years ago

Bada bing, bada boom.