dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
70 stars 19 forks source link

Fix all Harmony decoding #124

Closed DJBen closed 4 years ago

DJBen commented 4 years ago

LilyPondTest suite now has 59 failures.

codecov-io commented 4 years ago

Codecov Report

Merging #124 into latest will increase coverage by 5.47%. The diff coverage is 88.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest     #124      +/-   ##
==========================================
+ Coverage    52.2%   57.67%   +5.47%     
==========================================
  Files         218      218              
  Lines        2632     2800     +168     
==========================================
+ Hits         1374     1615     +241     
+ Misses       1258     1185      -73
Impacted Files Coverage Δ
Sources/MusicXML/Complex Types/Ornaments.swift 100% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Root.swift 100% <ø> (+100%) :arrow_up:
Sources/MusicXML/Complex Types/Bass.swift 100% <ø> (+100%) :arrow_up:
Sources/MusicXML/Complex Types/Degree.swift 100% <100%> (+100%) :arrow_up:
Sources/MusicXML/Complex Types/BassAlter.swift 100% <100%> (+100%) :arrow_up:
Sources/MusicXML/Complex Types/BassStep.swift 100% <100%> (+100%) :arrow_up:
Sources/MusicXML/Complex Types/DegreeAlter.swift 100% <100%> (+100%) :arrow_up:
Sources/MusicXML/Complex Types/DegreeValue.swift 100% <100%> (+100%) :arrow_up:
Sources/MusicXML/Complex Types/Slide.swift 100% <100%> (+100%) :arrow_up:
Sources/MusicXML/Complex Types/RootStep.swift 100% <100%> (+100%) :arrow_up:
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e22f50...91dedc8. Read the comment docs.

jsbean commented 4 years ago

🙌