Allow multiple Dynamics values per DirectionType

dn-m / MusicXML

Implementation of the musicXML specification in Swift

MIT License

70 stars 19 forks source link

Allow multiple Dynamics values per DirectionType #130

Closed jsbean closed 4 years ago

jsbean commented 4 years ago

The DirectionType.dynamics case currently holds onto a single Dynamics as its associated value.

In the MusicXML spec, however, there should be able to be a sequence of Dynamics values. In #126, we were able to decode a single Dynamics value, which seems to be the vastly more common case.

@DJBen, @bwetherfield, let me know if you've got thoughts on how to deal with this.

jsbean commented 4 years ago

The same problem occurs with coda, and rehearsal.