search

dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
74 stars 20 forks source link

Fix Directions LilyPond test #133

Closed jsbean closed 5 years ago

jsbean commented 5 years ago

This PR fixes the Direction decoding by way of sniffing through the 31a-Directions.xml LilyPond test until it doesn't smell bad anymore.

47 failures left.

codecov-io commented 5 years ago

Codecov Report

Merging #133 into latest will increase coverage by 2.81%. The diff coverage is 79.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest     #133      +/-   ##
==========================================
+ Coverage   59.57%   62.39%   +2.81%     
==========================================
  Files         219      220       +1     
  Lines        2894     2986      +92     
==========================================
+ Hits         1724     1863     +139     
+ Misses       1170     1123      -47
Impacted Files Coverage Δ
Sources/MusicXML/Complex Types/Position.swift 100% <ø> (ø) :arrow_up:
...ces/MusicXML/Simple Types/CommaSeparatedText.swift 0% <0%> (ø)
Sources/MusicXML/Complex Types/Dashes.swift 100% <100%> (+100%) :arrow_up:
Sources/MusicXML/Complex Types/PedalTuning.swift 100% <100%> (+100%) :arrow_up:
Sources/MusicXML/Complex Types/Pedal.swift 100% <100%> (+100%) :arrow_up:
Sources/MusicXML/Complex Types/HarpPedals.swift 100% <100%> (+100%) :arrow_up:
Sources/MusicXML/Complex Types/Offset.swift 100% <100%> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Note.swift 90% <100%> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Direction.swift 100% <100%> (ø) :arrow_up:
Sources/MusicXML/Complex Types/DirectionType.swift 49.01% <100%> (+6.86%) :arrow_up:
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 13c89bd...9e3829f. Read the comment docs.

jsbean commented 5 years ago

There are now three cases of #130, where the associated value of a choice type should be an array. I'm not sure if this is something we can treat at the MusicXML level or if we have to go down to XMLCoder.