search

dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
74 stars 20 forks source link

Fix LilyPond Notations test #134

Closed jsbean closed 5 years ago

jsbean commented 5 years ago

This PR fixes the LilyPond Notations test.

43 remaining LilyPond failures.

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (latest@1cdb933). Click here to learn what that means. The diff coverage is 89.13%.

Impacted file tree graph

@@            Coverage Diff            @@
##             latest     #134   +/-   ##
=========================================
  Coverage          ?   65.04%           
=========================================
  Files             ?      219           
  Lines             ?     3058           
  Branches          ?        0           
=========================================
  Hits              ?     1989           
  Misses            ?     1069           
  Partials          ?        0
Impacted Files Coverage Δ
Sources/MusicXML/Complex Types/Technical.swift 100% <100%> (ø)
Sources/MusicXML/Complex Types/StrongAccent.swift 100% <100%> (ø)
Sources/MusicXML/Complex Types/PlacementText.swift 100% <100%> (ø)
Sources/MusicXML/Complex Types/Notations.swift 63.21% <100%> (ø)
Sources/MusicXML/Complex Types/Articulations.swift 100% <100%> (ø)
...ources/MusicXML/Complex Types/EmptyPlacement.swift 100% <100%> (ø)
Sources/MusicXML/Complex Types/BreathMark.swift 100% <100%> (ø)
Sources/MusicXML/Complex Types/Technique.swift 52.72% <50%> (ø)
Sources/MusicXML/Complex Types/Articulation.swift 55.55% <66.66%> (ø)
Sources/MusicXML/Complex Types/Fret.swift 85.71% <81.81%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1cdb933...ef8b667. Read the comment docs.