search

dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
70 stars 19 forks source link

Convert #warning TODOs and FIXMEs to comments #156

Closed jsbean closed 4 years ago

jsbean commented 4 years ago

This PR converts the current methodology of using #warnings to using // (comments).

While the #warnings are convenient during development, they leak out to users of the library. We can still search for them as we need to.

codecov-io commented 4 years ago

Codecov Report

Merging #156 into latest will increase coverage by 0.01%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest     #156      +/-   ##
==========================================
+ Coverage   66.21%   66.23%   +0.01%     
==========================================
  Files         221      221              
  Lines        3392     3391       -1     
==========================================
  Hits         2246     2246              
+ Misses       1146     1145       -1
Impacted Files Coverage Δ
Sources/MusicXML/Complex Types/DirectionType.swift 50.47% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Opus.swift 0% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/ScorePart.swift 100% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Font.swift 100% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Lyric.swift 73.01% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Metronome.swift 79.54% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Score.swift 100% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/PageLayout.swift 0% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Credit.swift 0% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Time.swift 67.96% <100%> (ø) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 343f87f...a66a803. Read the comment docs.