search

dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
74 stars 20 forks source link

Streamline some naming and initializers #159

Closed jsbean closed 5 years ago

jsbean commented 5 years ago

This PR updates several names and initializers, as well as adds some static let forwards to underlying enum types for some types which are a bit clumsy to work with in the Swift source.

Highly source-breaking.

jsbean commented 5 years ago

I'll wait for #160 to merge, then we can restart the Travis CI PR test.

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (latest@995d9f6). Click here to learn what that means. The diff coverage is 74%.

Impacted file tree graph

@@           Coverage Diff            @@
##             latest    #159   +/-   ##
========================================
  Coverage          ?   66.3%           
========================================
  Files             ?     221           
  Lines             ?    3413           
  Branches          ?       0           
========================================
  Hits              ?    2263           
  Misses            ?    1150           
  Partials          ?       0
Impacted Files Coverage Δ
Sources/MusicXML/Complex Types/Degree.swift 100% <100%> (ø)
Sources/MusicXML/Complex Types/Inversion.swift 100% <100%> (ø)
Sources/MusicXML/Complex Types/BassStep.swift 100% <100%> (ø)
Sources/MusicXML/Complex Types/DegreeAlter.swift 100% <100%> (ø)
Sources/MusicXML/Complex Types/DegreeValue.swift 100% <100%> (ø)
...ources/MusicXML/Complex Types/MIDIInstrument.swift 100% <100%> (ø)
Sources/MusicXML/Complex Types/PartName.swift 100% <100%> (ø)
Sources/MusicXML/Complex Types/RootStep.swift 100% <100%> (ø)
Sources/MusicXML/Complex Types/DegreeType.swift 100% <100%> (ø)
...MusicXML/Complex Types/AccordionRegistration.swift 84.61% <100%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 995d9f6...cf49364. Read the comment docs.

bwetherfield commented 5 years ago

All set here, @jsbean