search

dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
70 stars 19 forks source link

De-label value arguments #163

Closed jsbean closed 4 years ago

jsbean commented 4 years ago

This PR more-systematically updates types which have a value.

This value is always first, and is always has no attribute labels in initializers.

Resolves #103.

jsbean commented 4 years ago

The next step to making this real nice is ensuring that each type like this is ExpressibleBy*Literal if their value is a String or Int or Double.

In the case of underlying enum values, adding static let type properties to the wrapping type that mirror the enum cases works ok, IMO.

codecov-io commented 4 years ago

Codecov Report

Merging #163 into latest will increase coverage by 0.13%. The diff coverage is 45.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest     #163      +/-   ##
==========================================
+ Coverage   66.68%   66.82%   +0.13%     
==========================================
  Files         221      221              
  Lines        3452     3448       -4     
==========================================
+ Hits         2302     2304       +2     
+ Misses       1150     1144       -6
Impacted Files Coverage Δ
Sources/MusicXML/Complex Types/Rights.swift 53.33% <ø> (+8.88%) :arrow_up:
Sources/MusicXML/Complex Types/Creator.swift 100% <ø> (+16.66%) :arrow_up:
Sources/MusicXML/Complex Types/NoteSize.swift 0% <0%> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Beater.swift 0% <0%> (ø) :arrow_up:
...urces/MusicXML/Complex Types/HammerOnPullOff.swift 0% <0%> (ø) :arrow_up:
...rces/MusicXML/Complex Types/MeasureNumbering.swift 0% <0%> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Feature.swift 0% <0%> (ø) :arrow_up:
Sources/MusicXML/Complex Types/OtherNotation.swift 0% <0%> (ø) :arrow_up:
Sources/MusicXML/Complex Types/PartSymbol.swift 0% <0%> (ø) :arrow_up:
...ources/MusicXML/Complex Types/PrincipleVoice.swift 0% <0%> (ø) :arrow_up:
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3c4a5c6...33d6df0. Read the comment docs.