dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
70 stars 19 forks source link

Establish a score test suite and add the very first test case #172

Closed DJBen closed 4 years ago

DJBen commented 4 years ago

Details please refer to ScoreTests/README.md. Let me know what you think of this structure.

codecov-io commented 4 years ago

Codecov Report

Merging #172 into latest will increase coverage by 0.19%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           latest    #172      +/-   ##
=========================================
+ Coverage    67.9%   68.1%   +0.19%     
=========================================
  Files         221     221              
  Lines        3546    3546              
=========================================
+ Hits         2408    2415       +7     
+ Misses       1138    1131       -7
Impacted Files Coverage Δ
...ces/MusicXML/Complex Types/Timewise/Timewise.swift 82.35% <0%> (+41.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2933e55...d67b1f1. Read the comment docs.

jsbean commented 4 years ago

This is great work, @DJBen, thank you! Would you want to inject the LilyPond test suite into this design? If so, would you want to do this in this PR or in a follow-up?

DJBen commented 4 years ago

This is great work, @DJBen, thank you! Would you want to inject the LilyPond test suite into this design? If so, would you want to do this in this PR or in a follow-up?

I would consider unifying both LilyPond and this more general score test suite. Given that LilyPond is a more specialized test group, I have the following thoughts:

I lean towards a follow up PR, perhaps after some time as we round up edges on the ScoreTestSuite. What do you think?

jsbean commented 4 years ago

This is great work, @DJBen, thank you! Would you want to inject the LilyPond test suite into this design? If so, would you want to do this in this PR or in a follow-up?

I would consider unifying both LilyPond and this more general score test suite. Given that LilyPond is a more specialized test group, I have the following thoughts:

  • Redesign the ScoreTestSuite so that it consists of test groups, each containing various test cases.
  • Turn LilyPondTestSuite into a test group

I lean towards a follow up PR, perhaps after some time as we round up edges on the ScoreTestSuite. What do you think?

I agree on all points.

I very much like the idea of test groups. The organization of those could be provenance (e.g., LilyPond, etc.) and/or genre and/or some other method.

A follow-up PR sounds like the way to go!

DJBen commented 4 years ago

I decode to make test group as a follow up.

jsbean commented 4 years ago

🎉