search

dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
74 stars 20 forks source link

Fix all the bits touched by the Après un Rêve sample score #176

Closed jsbean closed 5 years ago

jsbean commented 5 years ago

This PR fixes the failing test for the Après un Rêve score sample test.

codecov-io commented 5 years ago

Codecov Report

Merging #176 into latest will increase coverage by 1.58%. The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest     #176      +/-   ##
==========================================
+ Coverage    68.1%   69.69%   +1.58%     
==========================================
  Files         221      222       +1     
  Lines        3546     3557      +11     
==========================================
+ Hits         2415     2479      +64     
+ Misses       1131     1078      -53
Impacted Files Coverage Δ
Sources/MusicXML/Complex Types/SystemMargins.swift 100% <ø> (+100%) :arrow_up:
Sources/MusicXML/Complex Types/StaffLayout.swift 100% <ø> (+100%) :arrow_up:
Sources/MusicXML/Complex Types/Play.swift 0% <0%> (ø) :arrow_up:
Sources/MusicXML/Complex Types/EmptyFont.swift 0% <0%> (ø) :arrow_up:
Sources/MusicXML/Complex Types/NoteheadText.swift 0% <0%> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Supports.swift 100% <100%> (+100%) :arrow_up:
Sources/MusicXML/Complex Types/NoteSize.swift 100% <100%> (+100%) :arrow_up:
Sources/MusicXML/Complex Types/Appearance.swift 100% <100%> (+100%) :arrow_up:
Sources/MusicXML/Complex Types/SystemLayout.swift 100% <100%> (+100%) :arrow_up:
Sources/MusicXML/Complex Types/Defaults.swift 100% <100%> (+100%) :arrow_up:
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f3d5c8a...1225f7b. Read the comment docs.

jsbean commented 5 years ago

@DJBen, I removed the rêve expectation class for the time being, because it wasn't actually testing anything valid.

jsbean commented 5 years ago

Ah, sorry I merged prematurely. I’ll address this feedback in a follow-up PR.