search

dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
70 stars 19 forks source link

Turn off trimValueWhitespaces in XMLDecoder by default #177

Closed DJBen closed 4 years ago

DJBen commented 4 years ago

I am not sure about the benefit added by trimming value whitespaces; on the contrary, having the option turned on by default introduces potential bugs like https://github.com/MaxDesiatov/XMLCoder/pull/142

Let's turn it off, and later we may choose to turn it back on if sufficient value can be added and bugs can be fixed on XMLCoder's end.

What do you think?

jsbean commented 4 years ago

If all the tests pass I'm all for it!

codecov-io commented 4 years ago

Codecov Report

Merging #177 into latest will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           latest    #177   +/-   ##
======================================
  Coverage    68.1%   68.1%           
======================================
  Files         221     221           
  Lines        3546    3546           
======================================
  Hits         2415    2415           
  Misses       1131    1131
Impacted Files Coverage Δ
Sources/MusicXML/Decoding/Decoding.swift 87.5% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c3ad3a5...ec27cdf. Read the comment docs.