search

dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
74 stars 20 forks source link

Add test for Supports in Identification #180

Closed DJBen closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #180 into latest will increase coverage by 0.14%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest     #180      +/-   ##
==========================================
+ Coverage    68.1%   68.24%   +0.14%     
==========================================
  Files         221      221              
  Lines        3546     3546              
==========================================
+ Hits         2415     2420       +5     
+ Misses       1131     1126       -5
Impacted Files Coverage Δ
Sources/MusicXML/Complex Types/Supports.swift 100% <0%> (+100%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f3d5c8a...7350ce8. Read the comment docs.

jsbean commented 5 years ago

I actually cover this here.

DJBen commented 5 years ago

I actually cover this here.

This test covers Supports decoding within Identification. Didn't see this being covered?

jsbean commented 5 years ago

Ack, the link didn't really go to the right place: https://github.com/dn-m/MusicXML/blob/1225f7b6b780e4bf9d63a35e47ee87efa88e2a21/Tests/MusicXMLTests/ReveTests.swift#L14-L51.

jsbean commented 5 years ago

That is, I think the tests are identical :).

DJBen commented 5 years ago

That is, I think the tests are identical :).

gotcha