search

dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
70 stars 19 forks source link

[WIP / Do Not Merge] Create MusicXMLDecoder #181

Closed jsbean closed 4 years ago

jsbean commented 4 years ago

Resolves #179.

codecov-io commented 4 years ago

Codecov Report

Merging #181 into latest will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest     #181      +/-   ##
==========================================
+ Coverage   69.69%   69.72%   +0.03%     
==========================================
  Files         222      223       +1     
  Lines        3557     3561       +4     
==========================================
+ Hits         2479     2483       +4     
  Misses       1078     1078
Impacted Files Coverage Δ
Sources/MusicXML/Decoding/MusicXMLDecoder.swift 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5eea1c9...6853b97. Read the comment docs.

jsbean commented 4 years ago

@DJBen, I updated all usages of XMLDecoder to MusicXMLDecoder.

Setting trimValueWhitespaces to false solves the single case of the copyright symbol, though breaks many other tests.

It seems like this should really be solved upstream?

jsbean commented 4 years ago

We can give this a shot down the line once we feel good about the encoding process!