search

dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
70 stars 19 forks source link

Flatten MusicXML -> Score -> Traversal structure #184

Closed jsbean closed 4 years ago

jsbean commented 4 years ago

This PR addresses #166.

Now, Score is the first-class value, which is an enum with two cases, .timewise() and .partwise().

codecov-io commented 4 years ago

Codecov Report

Merging #184 into latest will decrease coverage by 0.05%. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest     #184      +/-   ##
==========================================
- Coverage   70.21%   70.16%   -0.06%     
==========================================
  Files         222      220       -2     
  Lines        3593     3586       -7     
==========================================
- Hits         2523     2516       -7     
  Misses       1070     1070
Impacted Files Coverage Δ
Sources/MusicXML/Complex Types/Technique.swift 77.06% <ø> (ø) :arrow_up:
...ces/MusicXML/Complex Types/Timewise/Timewise.swift 74.07% <100%> (ø) :arrow_up:
Sources/MusicXML/Decoding/Decoding.swift 87.5% <100%> (ø) :arrow_up:
...ces/MusicXML/Complex Types/Partwise/Partwise.swift 100% <100%> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Score.swift 46.15% <36.36%> (-53.85%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 95e6336...da1516a. Read the comment docs.