search

dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
74 stars 20 forks source link

Remove remaining Empty* types #190

Closed jsbean closed 5 years ago

jsbean commented 5 years ago

These Empty* types are a blight on the Swift API. They are really under the jurisdiction of (en|de)coding, and should only be exposed to those processes.

Resolves #178.

codecov-io commented 5 years ago

Codecov Report

Merging #190 into latest will decrease coverage by 0.03%. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest     #190      +/-   ##
==========================================
- Coverage   70.15%   70.11%   -0.04%     
==========================================
  Files         219      218       -1     
  Lines        3598     3594       -4     
==========================================
- Hits         2524     2520       -4     
  Misses       1074     1074
Impacted Files Coverage Δ
Sources/MusicXML/Complex Types/Line.swift 100% <ø> (ø)
Sources/MusicXML/Complex Types/Articulation.swift 55.55% <ø> (ø) :arrow_up:
...s/MusicXML/Complex Types/PlacementPrintStyle.swift 100% <ø> (ø)
Sources/MusicXML/Complex Types/Technique.swift 77.06% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Ornament.swift 53.84% <ø> (ø) :arrow_up:
.../MusicXML/Complex Types/PrintStyleTrillSound.swift 100% <ø> (ø)
...MusicXML/Complex Types/PrintStyleAlignObject.swift 0% <ø> (ø)
Sources/MusicXML/Complex Types/Mordent.swift 0% <0%> (ø) :arrow_up:
...ources/MusicXML/Complex Types/SystemDividers.swift 0% <0%> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Barline.swift 100% <100%> (ø) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6b849d2...959c72b. Read the comment docs.