dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
70 stars 19 forks source link

Tighten up attribute group encoding from #193 #195

Closed jsbean closed 4 years ago

jsbean commented 4 years ago

This PR is a follow up to #193 which tightens up the encoding of attribute groups.

codecov-io commented 4 years ago

Codecov Report

Merging #195 into latest will decrease coverage by 0.02%. The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest     #195      +/-   ##
==========================================
- Coverage   71.39%   71.37%   -0.03%     
==========================================
  Files         218      218              
  Lines        3671     3661      -10     
==========================================
- Hits         2621     2613       -8     
+ Misses       1050     1048       -2
Impacted Files Coverage Δ
Sources/MusicXML/Complex Types/PrintStyle.swift 100% <ø> (+12.5%) :arrow_up:
Sources/MusicXML/Simple Types/Tenths.swift 100% <100%> (ø) :arrow_up:
Sources/MusicXML/Complex Types/LyricFont.swift 100% <100%> (ø) :arrow_up:
Sources/MusicXML/Simple Types/Color.swift 63.15% <100%> (-1.85%) :arrow_down:
...MusicXML/Complex Types/AccordionRegistration.swift 100% <100%> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Technical.swift 100% <100%> (ø) :arrow_up:
...ources/MusicXML/Simple Types/AccordionMiddle.swift 100% <100%> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Harmonic.swift 93.18% <100%> (-0.16%) :arrow_down:
Sources/MusicXML/Simple Types/FontSize.swift 96.42% <50%> (-0.13%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e5e7e8c...ca272b4. Read the comment docs.