search

dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
74 stars 20 forks source link

Update value coding key dependency #197

Closed bwetherfield closed 4 years ago

bwetherfield commented 5 years ago

Changing the use of special case "value" key to the special case "" key as proposed in this PR and implemented in this active branch.

The only meaningful change I have needed besides adding a lot of case value = "" lines (with the help of Sourcery), is found in BreathMark.swift. I do think the implementation there now is probably as it should be now that an optional string type reads <optionalString/> as "" rather than nil.

codecov-io commented 5 years ago

Codecov Report

Merging #197 into latest will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest     #197      +/-   ##
==========================================
+ Coverage   71.37%   71.38%   +<.01%     
==========================================
  Files         218      218              
  Lines        3661     3662       +1     
==========================================
+ Hits         2613     2614       +1     
  Misses       1048     1048
Impacted Files Coverage Δ
Sources/MusicXML/Complex Types/NoteType.swift 100% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/NoteSize.swift 100% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Beam.swift 100% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Beater.swift 0% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Mordent.swift 0% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/MultipleRest.swift 100% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/TupletNumber.swift 0% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Distance.swift 100% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/GroupName.swift 0% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/TupletType.swift 0% <ø> (ø) :arrow_up:
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a02940e...eb696ae. Read the comment docs.

jsbean commented 5 years ago

Oh, this is great 🎉 !