dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
70 stars 19 forks source link

Add all music xml test samples to the test suite #199

Closed DJBen closed 4 years ago

DJBen commented 4 years ago

There are three failing samples exposing potential bugs. We can go bug hunting from there.

codecov-io commented 4 years ago

Codecov Report

Merging #199 into latest will increase coverage by 0.65%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest     #199      +/-   ##
==========================================
+ Coverage   71.38%   72.03%   +0.65%     
==========================================
  Files         218      218              
  Lines        3662     3662              
==========================================
+ Hits         2614     2638      +24     
+ Misses       1048     1024      -24
Impacted Files Coverage Δ
Sources/MusicXML/Complex Types/MusicData.swift 55.07% <0%> (+2.89%) :arrow_up:
Sources/MusicXML/Complex Types/Note.swift 98.7% <0%> (+4.54%) :arrow_up:
Sources/MusicXML/Complex Types/Lyric.swift 85.71% <0%> (+12.69%) :arrow_up:
...ces/MusicXML/Complex Types/Timewise/Timewise.swift 100% <0%> (+25.92%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 07e7706...9263cfc. Read the comment docs.

jsbean commented 4 years ago

Hey @DJBen, sorry for the delay. Do you think it is critical to have the PDF / PNGs here?

DJBen commented 4 years ago

Not at all. Feel free to remove them. I used a script to move the files and generate yaml files so they are included

Sent from my iPhone

On Nov 11, 2019, at 7:25 AM, James Bean notifications@github.com wrote:

 Hey @DJBen, sorry for the delay. Do you think it is critical to have the PDF / PNGs here?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

jsbean commented 4 years ago

@DJBen, I'm going to close this in favor of #200, where I removed the PNG and PDF files.

This is great, though! Let the whack-a-mole commence!