search

dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
70 stars 19 forks source link

Add all MusicXML test samples to the test suite #200

Closed jsbean closed 4 years ago

jsbean commented 4 years ago

This PR extends @DJBen's #199 by removing PDF and PNG files.

jsbean commented 4 years ago

@DJBen, I'd like to extend my gratitude for your work on the test suite, particular w/r/t the configurable severity of test failures. This makes hunting down these bugs a pleasure :).

codecov-io commented 4 years ago

Codecov Report

Merging #200 into latest will increase coverage by 0.65%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest     #200      +/-   ##
==========================================
+ Coverage   71.38%   72.03%   +0.65%     
==========================================
  Files         218      218              
  Lines        3662     3662              
==========================================
+ Hits         2614     2638      +24     
+ Misses       1048     1024      -24
Impacted Files Coverage Δ
Sources/MusicXML/Complex Types/MusicData.swift 55.07% <0%> (+2.89%) :arrow_up:
Sources/MusicXML/Complex Types/Note.swift 98.7% <0%> (+4.54%) :arrow_up:
Sources/MusicXML/Complex Types/Lyric.swift 85.71% <0%> (+12.69%) :arrow_up:
...ces/MusicXML/Complex Types/Timewise/Timewise.swift 100% <0%> (+25.92%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 07e7706...b6b3670. Read the comment docs.