Closed DJBen closed 4 years ago
Merging #202 into latest will increase coverage by
0.12%
. The diff coverage is94.82%
.
@@ Coverage Diff @@
## latest #202 +/- ##
==========================================
+ Coverage 72.03% 72.16% +0.12%
==========================================
Files 218 218
Lines 3662 3715 +53
==========================================
+ Hits 2638 2681 +43
- Misses 1024 1034 +10
Impacted Files | Coverage Δ | |
---|---|---|
Sources/MusicXML/Complex Types/Score.swift | 66.66% <100%> (+20.51%) |
:arrow_up: |
Sources/MusicXML/Decoding/Decoding.swift | 92.45% <93.47%> (+4.95%) |
:arrow_up: |
...ces/MusicXML/Complex Types/Timewise/Timewise.swift | 74.07% <0%> (-25.93%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d086c71...1527e3b. Read the comment docs.
Thank you so much for contributing this, @DJBen! Looks amazing. Just the one question I had regarding the use of XMLDecoder.userInfo
versus storing the relevant Score.CodingKeys
value directly.
This looks great to me!
partwise
documents MUCH more understandable because it will no longer be swallowed.timewise
documents because it will no longer attempt to parse it withpartwise
parser first.