dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
70 stars 19 forks source link

Using a data probing strategy, efficiently retrieve the top level tag to determine which top level parser to use #202

Closed DJBen closed 4 years ago

DJBen commented 4 years ago
codecov-io commented 4 years ago

Codecov Report

Merging #202 into latest will increase coverage by 0.12%. The diff coverage is 94.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest     #202      +/-   ##
==========================================
+ Coverage   72.03%   72.16%   +0.12%     
==========================================
  Files         218      218              
  Lines        3662     3715      +53     
==========================================
+ Hits         2638     2681      +43     
- Misses       1024     1034      +10
Impacted Files Coverage Δ
Sources/MusicXML/Complex Types/Score.swift 66.66% <100%> (+20.51%) :arrow_up:
Sources/MusicXML/Decoding/Decoding.swift 92.45% <93.47%> (+4.95%) :arrow_up:
...ces/MusicXML/Complex Types/Timewise/Timewise.swift 74.07% <0%> (-25.93%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d086c71...1527e3b. Read the comment docs.

bwetherfield commented 4 years ago

Thank you so much for contributing this, @DJBen! Looks amazing. Just the one question I had regarding the use of XMLDecoder.userInfo versus storing the relevant Score.CodingKeys value directly.

jsbean commented 4 years ago

This looks great to me!