search

dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
70 stars 19 forks source link

Make PageMargins type not required #204

Closed DJBen closed 4 years ago

DJBen commented 4 years ago

http://usermanuals.musicxml.com/MusicXML/MusicXML.htm#CT-MusicXML-page-margins.htm?Highlight=page-margins

All musicxml sample tests are passed.

codecov-io commented 4 years ago

Codecov Report

Merging #204 into latest will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           latest    #204      +/-   ##
=========================================
+ Coverage   72.28%   72.3%   +0.02%     
=========================================
  Files         218     218              
  Lines        3723    3723              
=========================================
+ Hits         2691    2692       +1     
+ Misses       1032    1031       -1
Impacted Files Coverage Δ
Sources/MusicXML/Complex Types/PageMargins.swift 100% <100%> (ø) :arrow_up:
Sources/MusicXML/Complex Types/DirectionType.swift 52.72% <0%> (+0.9%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 84c0d3c...e4f73d4. Read the comment docs.

DJBen commented 4 years ago

This is a trivial fix so I am going to merge it.