search

dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
70 stars 19 forks source link

Uniformize Attribute Group Usage #207

Closed bwetherfield closed 4 years ago

bwetherfield commented 4 years ago

Attribute groups are labeled : AttributeGroup internally, and are non-Optional when appearing as attribute group values.

codecov-io commented 4 years ago

Codecov Report

Merging #207 into latest will decrease coverage by 2.05%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest     #207      +/-   ##
==========================================
- Coverage    72.3%   70.25%   -2.06%     
==========================================
  Files         218      218              
  Lines        3723     3927     +204     
==========================================
+ Hits         2692     2759      +67     
- Misses       1031     1168     +137
Impacted Files Coverage Δ
Sources/MusicXML/Complex Types/BassAlter.swift 100% <ø> (ø) :arrow_up:
Sources/MusicXML/InternalTypes/Empty.swift 100% <ø> (ø)
Sources/MusicXML/Complex Types/Hole.swift 0% <0%> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Handbell.swift 0% <0%> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Arrow.swift 19.23% <0%> (-5.77%) :arrow_down:
...ources/MusicXML/Complex Types/AccidentalText.swift 65.9% <0%> (-34.1%) :arrow_down:
Sources/MusicXML/Complex Types/OtherNotation.swift 0% <0%> (ø) :arrow_up:
Sources/MusicXML/Complex Types/GroupName.swift 0% <0%> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Position.swift 100% <100%> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Fermata.swift 100% <100%> (ø) :arrow_up:
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6415654...c7b59f4. Read the comment docs.

jsbean commented 4 years ago

This is excellent, @bwetherfield. Thanks!