search

dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
70 stars 19 forks source link

Add SwiftFormat #208

Closed bwetherfield closed 4 years ago

bwetherfield commented 4 years ago

Using SwiftFormat

bwetherfield commented 4 years ago

@jsbean, --self init-only is an option if you prefer to see self in initializers!

jsbean commented 4 years ago

Let's add --self init-only!

codecov-io commented 4 years ago

Codecov Report

Merging #208 into latest will decrease coverage by 0.09%. The diff coverage is 72%.

Impacted file tree graph

@@           Coverage Diff           @@
##           latest   #208     +/-   ##
=======================================
- Coverage   68.09%    68%   -0.1%     
=======================================
  Files         218    218             
  Lines        4181   4169     -12     
=======================================
- Hits         2847   2835     -12     
  Misses       1334   1334
Impacted Files Coverage Δ
Sources/MusicXML/Complex Types/GroupBarline.swift 100% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Accord.swift 100% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Stick.swift 0% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Pedal.swift 100% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/SystemLayout.swift 100% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Forward.swift 0% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Offset.swift 100% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Wedge.swift 65.51% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Technical.swift 100% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Unpitched.swift 100% <ø> (ø) :arrow_up:
... and 205 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3a553e5...90b69cd. Read the comment docs.

bwetherfield commented 4 years ago

Ah, so I don't think it is that smart that we can revert any of these changes... might need to start from square one once we agree on some formatting rules

jsbean commented 4 years ago

That's ok! It's lookin' good to me.

bwetherfield commented 4 years ago

Re-ran things so as to cause less damage!