search

dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
70 stars 19 forks source link

Note Encoding Implementation #210

Closed bwetherfield closed 4 years ago

bwetherfield commented 4 years ago

Adds Roundtrip tests and encoding for Note

codecov-io commented 4 years ago

Codecov Report

Merging #210 into latest will increase coverage by 0.97%. The diff coverage is 83.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest     #210      +/-   ##
==========================================
+ Coverage      68%   68.98%   +0.97%     
==========================================
  Files         218      218              
  Lines        4169     4278     +109     
==========================================
+ Hits         2835     2951     +116     
+ Misses       1334     1327       -7
Impacted Files Coverage Δ
...rces/MusicXML/Complex Types/TimeModification.swift 100% <100%> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Beam.swift 100% <100%> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Notehead.swift 100% <100%> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Stem.swift 100% <100%> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Note.swift 89.17% <79.5%> (-9.51%) :arrow_down:
Sources/MusicXML/Complex Types/Notations.swift 85.39% <0%> (+21.34%) :arrow_up:
Sources/MusicXML/Complex Types/Tied.swift 100% <0%> (+34.37%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cd0f1d7...3be0975. Read the comment docs.

jsbean commented 4 years ago

🥇 This is great!