bwetherfield commented 4 years ago

Various encodings need to output as "yes"/"no" rather than true/false.

Leaving in sourcery tags for now, to allow easier modification.

codecov-io commented 4 years ago

Codecov Report

Merging #217 into latest will decrease coverage by 0.37%. The diff coverage is 41.89%.

@@            Coverage Diff             @@
##           latest     #217      +/-   ##
==========================================
- Coverage      65%   64.63%   -0.38%     
==========================================
  Files         220      220              
  Lines        4607     4649      +42     
==========================================
+ Hits         2995     3005      +10     
- Misses       1612     1644      +32

Impacted Files	Coverage Δ
Sources/MusicXML/Complex Types/Bend.swift	`34.48% <0%> (ø)`	:arrow_up:
Sources/MusicXML/Complex Types/BassAlter.swift	`52% <0%> (-16.43%)`	:arrow_down:
Sources/MusicXML/Complex Types/Mordent.swift	`26.08% <0%> (ø)`	:arrow_up:
Sources/MusicXML/Complex Types/DegreeAlter.swift	`50% <0%> (-14.71%)`	:arrow_down:
...ources/MusicXML/Complex Types/HorizontalTurn.swift	`64.7% <0%> (ø)`	:arrow_up:
Sources/MusicXML/Complex Types/NameDisplay.swift	`74.28% <0%> (-4.51%)`	:arrow_down:
Sources/MusicXML/Complex Types/Kind.swift	`55.26% <0%> (-22.52%)`	:arrow_down:
...MusicXML/Complex Types/PrintStyleAlignObject.swift	`63.63% <0%> (ø)`	:arrow_up:
Sources/MusicXML/Complex Types/Harmony.swift	`93.1% <0%> (-6.9%)`	:arrow_down:
Sources/MusicXML/Complex Types/RootAlter.swift	`48.14% <0%> (-13.76%)`	:arrow_down:
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3ca323b...29dd843. Read the comment docs.

jsbean commented 4 years ago

This is very nice! 🎉 :clap:

dn-m / MusicXML

Add Bool-to-YesNo conversion for encoding #217

Codecov Report