search

dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
70 stars 19 forks source link

Refactor assemble functionality for Key #220

Closed bwetherfield closed 4 years ago

bwetherfield commented 4 years ago

Places assemble in an extension of Decoder so as to have access to codingPath for error handling. This breaks with the previous convention which would have had assemble as a static function in KeyComponent. Does this seem acceptable to you guys, @jsbean , @DJBen ?

codecov-io commented 4 years ago

Codecov Report

Merging #220 into latest will increase coverage by <.01%. The diff coverage is 51.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest     #220      +/-   ##
==========================================
+ Coverage    65.1%   65.11%   +<.01%     
==========================================
  Files         220      220              
  Lines        4643     4644       +1     
==========================================
+ Hits         3023     3024       +1     
  Misses       1620     1620
Impacted Files Coverage Δ
Sources/MusicXML/Simple Types/YesNoNumber.swift 0% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/MeasureStyle.swift 71.42% <100%> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Key.swift 74.5% <50.76%> (+0.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f73604...5683b39. Read the comment docs.