search

dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
70 stars 19 forks source link

Implement DynamicNodeEncoding #232

Closed bwetherfield closed 3 years ago

codecov-io commented 4 years ago

Codecov Report

Merging #232 into latest will decrease coverage by 6.67%. The diff coverage is 15.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest     #232      +/-   ##
==========================================
- Coverage   66.48%   59.81%   -6.68%     
==========================================
  Files         220      221       +1     
  Lines        4700     5403     +703     
==========================================
+ Hits         3125     3232     +107     
- Misses       1575     2171     +596
Impacted Files Coverage Δ
Sources/MusicXML/Complex Types/ScorePart.swift 100% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/LyricLanguage.swift 0% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Ending.swift 100% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Offset.swift 45.45% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/NoteType.swift 88.88% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/GroupSymbol.swift 45% <ø> (ø) :arrow_up:
...usicXML/Complex Types/Partwise/Partwise.Part.swift 100% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/KeyOctave.swift 100% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Fret.swift 100% <ø> (ø) :arrow_up:
Sources/MusicXML/Complex Types/Barline.swift 64.7% <0%> (-35.3%) :arrow_down:
... and 129 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1fdf3c5...8fabb45. Read the comment docs.

yuryks commented 3 years ago

Will it be merged to mater branch ?

bwetherfield commented 3 years ago

Hmmm, yeah looks like it doesn't break anything