search

dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
74 stars 20 forks source link

Use vars instead of lets so that compiler can build init #86

Closed jsbean closed 5 years ago

jsbean commented 5 years ago

@DJBen, I realized that you added inits for MIDIInstrument and ScorePart. I have started using vars instead of lets in this case so that the compiler will build the partial init for us.

This isn't consistent yet throughout the codebase, but it is the desired direction.

Let me know if that is unsavory for you!

codecov-io commented 5 years ago

Codecov Report

Merging #86 into latest will increase coverage by 0.27%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest      #86      +/-   ##
==========================================
+ Coverage   41.36%   41.64%   +0.27%     
==========================================
  Files          44       43       -1     
  Lines        1279     1268      -11     
==========================================
- Hits          529      528       -1     
+ Misses        750      740      -10
Impacted Files Coverage Δ
...es/MusicXML/Complex Types/PitchUnpitchedRest.swift 59.09% <ø> (-1.78%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7ef1f91...835cd43. Read the comment docs.