search

dn-m / MusicXML

Implementation of the musicXML specification in Swift
MIT License
74 stars 20 forks source link

Add assertion to PartwisePartTests.testDecodingSingleMeasure() #97

Closed jsbean closed 5 years ago

jsbean commented 5 years ago

This PR actually asserts the validity of the decoding of a basic single measure line.

This exists both to get rid of the #warning and to sniff out ways to improve the Note initializer API. A follow-up PR will attempt to make creating a Note slightly more manageable.

codecov-io commented 5 years ago

Codecov Report

Merging #97 into latest will increase coverage by 0.81%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           latest      #97      +/-   ##
==========================================
+ Coverage   43.75%   44.57%   +0.81%     
==========================================
  Files          45       45              
  Lines        1314     1326      +12     
==========================================
+ Hits          575      591      +16     
+ Misses        739      735       -4
Impacted Files Coverage Δ
Sources/MusicXML/Complex Types/MusicData.swift 60.81% <0%> (+14.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c34b744...38c59d3. Read the comment docs.