search

dnaaun / openFraming

Tools for automatic frame discovery and labeling based on topic modeling and deep learning, made widely accessible to researchers from non computational backgrounds.
http://www.openframing.org
9 stars 7 forks source link

LDA topic name assignment doesn't work #294

Closed asmithh closed 4 years ago

asmithh commented 4 years ago

https://drive.google.com/file/d/1lxM102gHQRZZtfUuiTmEkCE7zHdE8dJ8/view?usp=sharing

^ there's a video of the bug in action.

basically once you have a trained LDA model and you open that landing page, the next step would be to enter the names of the topics the model discovered. however, the first time you do that and click submit, nothing happens. if you then click on the button again, no matter how many labels you enter (regardless of whether it is the correct number of labels or not) you get a "you have the wrong number of labels" error message.

This occurs on Chrome on macOS; not sure if this also occurs on other browser/OS combinations.

dnaaun commented 4 years ago

Hi @lentil-soup , until we start echoing back to the user the error messages the backend gives, I don't think we should concern ourselves with such error messages, because we have no idea what the backend actually said. I vote for closing this until we get the frontend to echo back to the user the error messages the backend gives( #293 )

asmithh commented 4 years ago

I'm not concerned with error messages so much as the fact that you can't download your results...

On Thu, Jul 16, 2020, 10:09 AM davidatbu notifications@github.com wrote:

Hi @lentil-soup https://github.com/lentil-soup , until we start echoing back to the user the error messages the backend gives, I don't think we should concern ourselves with such error messages, because we have no idea what the backend actually said. I vote for closing this until we get the frontend to echo back to the user the error messages the backend gives(

293 https://github.com/davidatbu/openFraming/issues/293 )

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/davidatbu/openFraming/issues/294#issuecomment-659437424, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO2OVYFWCF2BMR5OBSCQNBTR34CZTANCNFSM4OZ2KCDA .

dnaaun commented 4 years ago

For documentation purposes, I'd like to leave a comment saying that, in addition to #308 which fixed the naming issue, the bug of not being able to download your results that @lentil-soup mentoined in the comments was fixed(barring "other" bugs in the frontend).