search

dnaaun / openFraming

Tools for automatic frame discovery and labeling based on topic modeling and deep learning, made widely accessible to researchers from non computational backgrounds.
http://www.openframing.org
9 stars 7 forks source link

push to deploy #298

Closed dnaaun closed 4 years ago

dnaaun commented 4 years ago

@davidatbu could you please provide some comments here? Since you have requested for our reviews but I was not sure exactly what is my review requested on.

monajalal commented 4 years ago

I think for now only have a docker that supports GPU only machines. (however, we can add it in our README.md if you have a CPU only machine or a machine that doesn't have NVIDIA GPUs, please use this line instead). We should brand ourself as fast response time since we are using GPU. Like @edward-edberg mentioned last night, our runtime has significantly has reduced and that's very good for us and we should brag about it (e.g. in Camera-ready later on)

dnaaun commented 4 years ago

Hi @monajalal , I didn't request a review here. It says "One review required" because I set it that way to make people think twice before merging to the "deployment" branch. But I've been overriding that with administrator rights to push to the deployment branch. May be that's what made you think I requested a review?

Just FYI, this code supports both GPU and CPU. If the system has a GPU, it will use it, if not, it will use CPU.

Also, I think the conversation about the GPUs belongs in an email thread with the professors, since it's less about the code, and more about finance/etc.