search

dnaaun / openFraming

Tools for automatic frame discovery and labeling based on topic modeling and deep learning, made widely accessible to researchers from non computational backgrounds.
http://www.openframing.org
9 stars 7 forks source link

Add error handling to framing.html #336

Closed vidyaap closed 3 years ago

dnaaun commented 3 years ago

Hi @vidyaap , thank you for your work on this. I finally found some breathing room to address this issue.

First, I wanna fix the failing tests. The Docker configuration has some outdated links. Once I fix that, I'll rebase this branch on the latest master and review your changes. Should be straightforward since you didn't touch the Docker conf in this PR.

vidyaap commented 3 years ago

Sounds good! These are really minor changes, just checking before doing the same thing on LDA

dnaaun commented 3 years ago

Hi @vidyaap , thanks for the PR. I tested it out and it looks great. One error that I coudl easily produce, but was not caught was 413 (Request Entity Too Large).

We didn't discuss this (we only discussed echoing back JSON error messages from the backend). But it would be nice to have :)