dnadesign / silverstripe-elemental-userforms

Adds a new element for usersforms
BSD 3-Clause "New" or "Revised" License
9 stars 16 forks source link

Two Forms on One Page #20

Closed asecondwill closed 6 years ago

asecondwill commented 6 years ago

If i add two UserForm elements to a page, the second form has it's fields hidden. Seems like it is thinking the second form is actually a second page of one form.

Markup responsible for hiding the fields:

<div id="EditableFormStep_0f006" class="form-step field CompositeField userformsstep" data-title="First Page" aria-hidden="true" style="display: none;">
asecondwill commented 6 years ago

Also, if you submit the page, the Thanks message shows on both forms.

robbieaverill commented 6 years ago

Thanks for reporting. It seems like there are two issues here:

asecondwill commented 6 years ago

Any Likely ETA on this? Early 2018?

asecondwill commented 6 years ago

Thinking about this, it's a problem with UserForms however two of them end up on a page together.

EG, if I pull one into the footer, say a NewsLetter signup form - it will not show it's fields on any UserForm page.

Should I open a ticket over in userforms?

https://github.com/silverstripe/silverstripe-userforms/issues

robbieaverill commented 6 years ago

Yeah if you don't mind that'd be cool

asecondwill commented 6 years ago

They are saying won't fix.

That means that every little form required in a footer etc needs to be hard coded.

not great at all.

robbieaverill commented 6 years ago

Hi @asecondwill, we will fix this. The comment on that userforms issue was from when this feature didn't exist - it does now.

robbieaverill commented 6 years ago

Linked issues: dnadesign/silverstripe-elemental#176 and silverstripe/silverstripe-userforms#543

NightJar commented 6 years ago

Already seemed to work pretty welll, but tidy up fixes in https://github.com/silverstripe/silverstripe-userforms/pull/715

asecondwill commented 6 years ago

This is great. thanks. Ill test this week on the site where this came up. thanks!