search

dnadesign / silverstripe-elemental-userforms

Adds a new element for usersforms
BSD 3-Clause "New" or "Revised" License
9 stars 16 forks source link

update finished function, issue-27 #78

Closed sukhwinder-somar closed 1 year ago

sukhwinder-somar commented 1 year ago

Issue https://github.com/dnadesign/silverstripe-elemental-userforms/issues/27

sukhwinder-somar commented 1 year ago

I was getting same error which has been mentioned in Issue 27 i.e. I added that and I do have deployed my changes to the prod on our project and I think it's been 3 months now since I have deployed the changes to prod and doesn't seems to cause any issue so far, Also this is only half part of fix, I also had to make changes in silverstripe-elemental in ElementalContentControllerExtension.php - https://github.com/dnadesign/silverstripe-elemental-userforms/issues/27#issuecomment-1679667651

GuySartorelli commented 1 year ago

Also this is only half part of fix, We also had to made changes in silverstripe-elemental in ElementalContentControllerExtension.php

Can you please create a pull request which introduces those changes? This PR is not useful without the full fix.

sukhwinder-somar commented 1 year ago

Hi,

Sure, just created a new PR for other changes, please let me know if something needs to be changed thanks