search

dnadesign / silverstripe-elemental-virtual

Allows Content Blocks to be reused between pages.
BSD 3-Clause "New" or "Revised" License
7 stars 26 forks source link

Changes so that elements can be moved to a different location instead of copying #19

Closed Hels666 closed 5 years ago

Hels666 commented 5 years ago

I made 2 small changes:

  1. made the element unlink instead of delete (to allow it to be re-linked in a new location)
  2. made all new elements globally available by default so they cant be accidentally lost if they get unlinked without that box (hidden on secondary tab) being ticked

new usage workflow:

  1. unlink element where it is now
  2. use the link existing search box to add it to a new location

caveat: you have to do the unlink step first because it won't allow the original to be unlinked if it gets copied first

I made these changes because that is the behaviour I was expecting of the module - please see my issue #445 on the silverstripe-elemental module (https://github.com/dnadesign/silverstripe-elemental/issues/445) It is also raised in issue #10 on this module. Additionally, there is discussion about it in the slack archive website, channel= content-blocks, question asked at 2018-08-08 16:28:25 then response thread started at 2018-08-08 17:14:08 (sorry, can't find permalink to messages)

Please let me know if I need to make any modifications or do anything extra (my first pull request for code!!) Thanks :-)