search

dnadesign / silverstripe-elemental-virtual

Allows Content Blocks to be reused between pages.
BSD 3-Clause "New" or "Revised" License
7 stars 26 forks source link

Replace virtual block svg with font-icon to be consistent with CMS pattern library #33

Closed sachajudd closed 3 years ago

sachajudd commented 4 years ago

I've added block-link to our core font set which I suggest should be replaced with the current svg to be consistent with our CMS pattern library. See https://github.com/silverstripe/silverstripe-admin/pull/1003 for the new block-icon set.

Current: image

Replacement (in context with font-icon-block- icons): image

Let me know what you think! 🙂

lerni commented 4 years ago

@sachajudd looks alot like https://github.com/dnadesign/silverstripe-elemental-virtual/pull/32

sachajudd commented 4 years ago

Cool thanks for that @lerni, I've just linked the two together and left a review.

lerni commented 3 years ago

@sachajudd - it's merged but not released yet. Can this be closed anyway?