dnadesign / silverstripe-elemental-virtual

Allows Content Blocks to be reused between pages.
BSD 3-Clause "New" or "Revised" License
7 stars 26 forks source link

Duplicate titled elements cause element virtual to not link to the correct element #55

Closed UndefinedOffset closed 1 year ago

UndefinedOffset commented 1 year ago

Since TagField uses the title of the element for both the label and value, this can cause issues if there are elements that have duplicate titles somewhere on the site. This can be exaggerated by sites using Fluent since it's possible that across locales there are duplicate titles. If a duplicate title is encountered only the first one is ever able to be linked. Perhaps tag field is not the right field to be used here or a subclass should be used that forces the value to be a numeric id.