search

dnaeon / go-vcr

Record and replay your HTTP interactions for fast, deterministic and accurate tests
BSD 2-Clause "Simplified" License
1.26k stars 78 forks source link

interaction duration is never set #62

Closed JVecsei closed 3 years ago

JVecsei commented 3 years ago

Hi,

I saw that there is some code to simulate the request duration ( https://github.com/dnaeon/go-vcr/blob/master/recorder/recorder.go#L234 ) but it seems this duration is not set when recording the interaction ( https://github.com/dnaeon/go-vcr/blob/master/recorder/recorder.go#L132 ).

Is there a plan on how and when this will be supported?

Thanks in advance!

dnaeon commented 3 years ago

Hey @JVecsei ,

I've opened up the following PR:

Let's use #63 to discuss this feature. Also, please test it out and let me know how it goes.