search

dnagir / ios-checkboxes

iOS style checkboxes for Rails 3.1
24 stars 9 forks source link

Please release it #1

Closed dnagir closed 12 years ago

dnagir commented 12 years ago

Hi @tdreyno,

Could you please release this gem? It provides built-in assets via SASS as well as native implementation with CoffeeScript (no need to precompile).

To push just do:

git clone git@github.com:dnagir/ios-checkboxes.git
cd ios-checkboxes
bundle install
rake release

Or you can give me access to this gem so that I can do it.

Thanks a lot.

tdreyno commented 12 years ago

Which gem do you need access to? The rails extension?

tdreyno commented 12 years ago

Hmm, I may not be correct, but I think you should namespace all your code, including tasks and assets under a folder. Rubygems is kind of nasty, it basically just throws everything into a pile so your assets/tasks could possibly other write some others. I think Railtie uses vendor/ for extra stuff which isn't available to ruby gems, but rails can find? Not entirely sure. I'd checkout something canonical like jquery-rails

dnagir commented 12 years ago

@tdreyno, I am talking about the rails gem you used to maintain http://rubygems.org/gems/ios-checkboxes (it is in the rails folder in your repo).

I could name this one differently, but don't think we need 2 competitive ones. We'd rather work both on one. But it's ok if you want to keep the ownership of the gem. I just want you to be able to release if possible.

As for namespacing.

Maybe I'm missing something, but I haven't had issues before with such structure. And it seems to be pretty common. In any case, you have the acces to the repo and feel free to commit. Just run the specs.

BTW, I have been screencasting making of this gem. If the Video will ever be uploaded to Vimeo, I'll share with you (if you're intered of course).

tdreyno commented 12 years ago

Right, your first bullet point is exactly what I mean. Assets go in the vendor directory.

So, I'd prefer if you'd submit a pull request to the original repo which incorporates your changes (that repo and URL is linked to from thousands of sites, I'd hate to break those links). I'll add you as a maintainer on the gem so you can do releases.

What email address do you have an account on RubyGems.org with?

dnagir commented 12 years ago

Ok. If it's a big deal where to store the assets, I'll move those to vendor. I personally look at vendor directory as 3-rd party set of libraries. In our case it's not 3rd party. It is the library. But technically it doesn't seem to matter.

What's interesting is that by creating this repo, I wanted to keep coffeescript, sass and images as one logical piece of functionality rather than in multiple repos/places.

The benefits of keeping it as a Rails plugin instead of separate independent files are:

What I really thought about is to use ios-checkboxes with Rails as a canonical and original source. And also precompile for non-Rails.

But I had to talk to you about it. I'm not sure if you are ok with it. What cons do you see with it?

As for existing links. We can maintain submodule (much like you currently do with SASS). I definitely think Rails plug-in should be in a separate repo.

Yeah, my email - dnagir@gmail.com.

Cheers.

tdreyno commented 12 years ago

Makes sense, as long as this new repo can compile a raw JS file.

You're added to the ios-checkboxes gem.

dnagir commented 12 years ago

Thanks a lot for that.

It seems I'm done with the stuff I needed:

  1. build standalone (also compresses and adds md5 hash to files).
  2. customisable SASS

Do you think https://github.com/tdreyno/iphone-style-checkboxes/tree/master/rails into a git submodule pointing to this repo Or maybe we'll just update README there to redirect a user to this repo?