search

dnagir / knockout-rails

KnockoutJS for Rails with Sweetness
96 stars 16 forks source link

Serversite error handling, rails "compatible" validatotors, new event callbacks, validator generation from rails and more #7

Closed simcha closed 10 years ago

simcha commented 10 years ago

Dmytrii, My colleague Krzysztof Madejski has upgraded your nice tool for use in our project. I have rewritten specs to mirror the changes. I would like to ask you to have a look. Merge or give me some guidelines as what to change. Changes are described in the README.md Thanks in advance and thanks for knockout-rails. Jan

dnagir commented 10 years ago

I don't know. This is a bit too large PR to merge especially taking into account number of breaking changes dropped bindings and extensions introduced.

But since I'm not maintaining this repo I shouldn't be complaining. Unless someone wants to take over this repo and proper maintenance I'd probably prefer you to keep this work in your fork.

simcha commented 10 years ago

Dmytrii, we find your work very valuable and we use knockout-rails in 2 of our (in4mates) projects. Thanks for reviewing our work. If you are not planing to maintain the repo and there is no one that is willing to do it, I would volunteer to do it. First of course I would need to fix errors you found and rewrite read.me. I will of course understand if you prefer me not to maintain the repo. Thanks again Jan

dnagir commented 10 years ago

@simcha I'll add you as the contributor to this repo. But be a little careful as I won't be able keep a close eye on it.

Good luck with it and thanks.

dnagir commented 10 years ago

Now @simcha and @jaredjenkins are collaborators on this repo. Please coordinate your actions together.

Thanks.