Closed jayvdb closed 1 month ago
I am pretty sure that "instantations" has been fixed in LLVM, if it was from there. So fixing it here would be consistent.
If you were to re-open this, I would drop the change to CHANGELOG.md since it is generated.
You're right. I did a quick search on the LLVM repo and except for some comment it was all corrected at some point. Was even thinking it wasn't a typo but a different correct spelling of the same word :sweat_smile:.
I think you don't have to revert that change on the changelog. I'll revert it and merge it. Next time the changelog is re-generated the fixes will simply disappear.
Thanks for the PR and sorry for the very long delay in replying. I've already looked at it a while ago but always forgot to answer.
I really appreciate the effort and typos should always be fixed. However, In the end I won't merge this for two reasons:
CHANGELOG.md
is generated from git-cliff, thus fixing anything manually in that file will be overwritten next time I run it. Those typos originate from the commit history and will stay with us forever :Dinstantations
is, if I recall correctly, coming from the LLVM codebase of the original code coverage tool (which is shipped with the Rust toolchain and does all the heavy lifting of the code coverage). Therefore, I'd like to keep it that way to keep things consistent.