dnaka91 / llvm-cov-pretty

More beautiful HTML reports for llvm-cov/cargo-llvm-cov
GNU Affero General Public License v3.0
28 stars 3 forks source link

Fix typos #11

Closed jayvdb closed 1 month ago

dnaka91 commented 1 month ago

Thanks for the PR and sorry for the very long delay in replying. I've already looked at it a while ago but always forgot to answer.

I really appreciate the effort and typos should always be fixed. However, In the end I won't merge this for two reasons:

jayvdb commented 1 month ago

I am pretty sure that "instantations" has been fixed in LLVM, if it was from there. So fixing it here would be consistent.

If you were to re-open this, I would drop the change to CHANGELOG.md since it is generated.

dnaka91 commented 1 month ago

You're right. I did a quick search on the LLVM repo and except for some comment it was all corrected at some point. Was even thinking it wasn't a typo but a different correct spelling of the same word :sweat_smile:.

I think you don't have to revert that change on the changelog. I'll revert it and merge it. Next time the changelog is re-generated the fixes will simply disappear.