dnanexus-archive / viral-ngs

viral-ngs
6 stars 6 forks source link

Aligner options not being passed to viral-ngs-assembly-analysis #60

Closed tomkinsc closed 7 years ago

tomkinsc commented 7 years ago

Background: In the script for viral-ngs-assembly-analysis, an aligner option string is passed to read_utils.py align_and_fix via --aligner_options.

Problem: In the shell script, the variable is called novoalign_options, however in the config json file, the variable is called aligner_options. Due to this inconsistency, the aligner option string is never passed to align_and_fix. This is confirmed via the logfile on DNAnexus, which reports the call, [...] -data/all.bam aligner_options= JVMmemory=4g [...] In the workflow setup, the variable is also called aligner_options.

Suggested resolution: In the shell script, change novoalign_options to aligner_options.