search

dnanexus-rnd / GLnexus

Scalable gVCF merging and joint variant calling for population sequencing projects
Apache License 2.0
145 stars 37 forks source link

Remove const qualifier on BCFData::dataset_header #185

Closed xunjieli closed 4 years ago

xunjieli commented 4 years ago

Hi Mike, BCFKeyValueData::dataset_header modifies the cache state, and it's not a const method in the strict sense. Do you think it's a good idea to remove the const qualifier on the parent method BCFData::dataset_header ?

I am currently trying to implement BCFData interface with my own cache backend. The const method signature makes it difficult to override dataset_header in a cache aware manner.

xunjieli commented 4 years ago

Seems no callsite is depending on this method being const? I created #186

xunjieli commented 4 years ago

@mlin

mlin commented 4 years ago

Sure, I have no problem with removing it.