dnanexus-rnd / GLnexus

Scalable gVCF merging and joint variant calling for population sequencing projects
Apache License 2.0
142 stars 37 forks source link

Improve handling haploid calls #230

Open VorontsovIE opened 4 years ago

VorontsovIE commented 4 years ago

Here are four fixes which should improve handling haploid genotypes:

This patch should fix #162.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.09%) to 93.315% when pulling 47e9465a714cdfa3057a4cc415546943693617a7 on VorontsovIE:fix_haploid_calls into ca0e9b774c8006faa5c3d7659f89653bbbc92d6b on dnanexus-rnd:master.

mlin commented 4 years ago

@VorontsovIE my apologies for the slow uptake on this. It looks just right to me, but I'd like to add a new gVCF test case to lock it down against future changes. I do still have those DRAGEN gVCFs for CEU trio, but I need to get to it.........has this diff unblocked you for the time being?

Also, I really appreciate how you were able to dig into the different parts of the genotyper code. You might have seen we're considering important changes to how it works in the medium-term future, specifically around multiallelic sites. Really eager for community feedback on that from any interested parties!