search

dnanexus / UKB_RAP

Access share reviewed code & Jupyter Notebooks for use on the UK Biobank (UKBB) Research Application Platform. Includes resources from DNAnexus webinars, online trainings and workshops.
MIT License
106 stars 45 forks source link

Quotes and name problem in partD-step1-regenie.sh #17

Closed kmcgurk closed 1 year ago

kmcgurk commented 1 year ago

Hey Anastazie,

Really love the code you have provided and your DNA Nexus tutorials!

I've noticed an issue to the GWAS code partD-step1-regenie.sh: I think this line: -icmd=${run_plink_wes} should read: -icmd="${run_regenie_step1}"

Also I noticed you added ";" at the end of the chunks of code for part D only - they're not in the other parts, maybe they don't have an effect but I haven't added them just in case!

Thanks,

Kathryn

anastazie-dnanexus commented 1 year ago

Thank you. Closing because you fix it in PR #18