search

dnanexus / dx-toolkit

DNAnexus platform client libraries
http://autodoc.dnanexus.com/
Apache License 2.0
90 stars 85 forks source link

APPS-2590 NPA script - Fix exit code of head job #1367

Closed r-i-v-a closed 4 months ago

r-i-v-a commented 4 months ago

Was introduced between releases – no changelog note. 

r-i-v-a commented 4 months ago

See Jira ticket for test runs.

mhrvol commented 4 months ago

There will be a left over process in the job. Will the job always exit properly?

I assume you've tested this. thus LGTM

r-i-v-a commented 4 months ago

There will be a left over process in the job. Will the job always exit properly?

I assume you've tested this. thus LGTM

It still does kill "$AWS_RELOGIN_PID"

It didn't fail to exit in any tests or in a test on staging with AWS login (linked on ticket).