search

dnanhkhoa / nb_black

A simple extension for Jupyter Notebook and Jupyter Lab to beautify Python code automatically using black.
MIT License
367 stars 41 forks source link

Extra quotes in setup.py break other tools #17

Open michaelaye opened 4 years ago

michaelaye commented 4 years ago

In your setup.py these extra ' quotes break conda builds and are not required, I think:

"yapf >= '0.28'; python_version < '3.6'",
"black >= '19.3'; python_version >= '3.6'",

I think they should be better:

"yapf >= 0.28; python_version < 3.6",
"black >= 19.3; python_version >= 3.6",

Maybe you try if your build process works without them (I think they should) and then you could remove these quotes?

dnanhkhoa commented 4 years ago

Thank you @michaelaye, I will update it soon.

homocomputeris commented 4 years ago

Also, in setup.py, both master and dev have

name="nb_black",
    version="1.0.6",

but on PyPI it's 1.0.7.

nivintw commented 3 years ago

It looks like master has been updated with the PR to fix this issue, but a new version hasn't been pushed to PyPI. Please push an update to PyPI so users don't have to install from source. Thanks!

PaulJWright commented 1 year ago

This issue is still a problem: https://pypi.org/project/nb-black/#files