search

dnarayanan / powderday

powderday dust radiative transfer
BSD 3-Clause "New" or "Revised" License
22 stars 17 forks source link

Solar metallicitity is now accessed through the sp object #196

Closed prerakgarg07 closed 2 years ago

prerakgarg07 commented 2 years ago

As of dfm/python-fsps#182 solar metallicity is now saved in the stellar population object.

We use this by default now and revert back to using fixed metallicity values if the user is using an older hash of python-fsps.

In the near future, the use of fixed metallicity will be dropped altogether and now a warning is issued in this regard asking the user to update python-fsps.

Bug fix:

  1. m_gen was being called twice which has now been fixed. This bug was introduced in commit #170
  2. As per the suggestion of #187 ds_type and m_gen have been reordered accordingly.