search

dnarayanan / powderday

powderday dust radiative transfer
BSD 3-Clause "New" or "Revised" License
22 stars 16 forks source link

Nebular Emission: Bug Fixes #210

Closed prerakgarg07 closed 1 year ago

prerakgarg07 commented 1 year ago

Fixed two critical bugs in nebular emission:

  1. When calculating the ionizing flux escape fraction is no longer taken into consideration since the covering factor takes care of that. The number of photons striking the inner surface of the cloud is independent of the escape fraction.
  2. The cloudy calculation now correctly stops when the fraction of ionized hydrogen drops below 0.1

Updated Parameters:

  1. HII_alpha_enhancement is changed to alpha_enhancement and now works as a toggle for turning on/off alpha enhancement for both HII regions and post AGB stars

Misc changes

  1. Moved alpha enhancement calculation to its own function in SED_gen to make the code easier to follow.
  2. Replaced logs with comments in cloudy_model.py