search

dnarayanan / powderday

powderday dust radiative transfer
BSD 3-Clause "New" or "Revised" License
22 stars 17 forks source link

yt4.x broken in octree building: impacts ALL runs with yt 4.x #85

Closed dnarayanan closed 4 years ago

dnarayanan commented 4 years ago

after a very long conversation and debugging session with @AshKelly we discovered that there's a bug in yt4.x that causes particle indices to change when re-loading a ds without a bounding box:

https://github.com/yt-project/yt/issues/2612

this is an issue here because we first load the ds to name the fields, and then reload in zoom in a zoomed-in region. note, yt 4.x works just fine before commit https://github.com/AshKelly/yt/commit/ae7ca617059e14098d13f45a98e6a1b5f2c11381 in ashkelly's fork (yt-4.0-new-octree branch) which merges in from master (the offending commit in master is listed in the above issue).

for now, no yt4.x for gadget/gizmo sims until this is fixed in yt, or use the commits listed above.

dnarayanan commented 4 years ago

this is addressed in this PR:

https://github.com/yt-project/yt/pull/2618

though this is not yet merged into mainline yt.

note, this may impact arepo runs as well, and so it is safest to run from hash db35aa511619845fce57b5694e37be9ff8821723 or before on the yt-4.0-new-octree branch of @AshKelly 's fork

dnarayanan commented 4 years ago

this has been merged into yt mainline